adding additional examples on how to use annotations and healthchecks #861

Jinkxed · 2019-02-20T15:11:37Z

I added two real examples on how we use the ALB Ingress controller both on internal application load balancers and external application load balancers.

I was unsure on where you would like to link to these examples, but please link to or use however you would like.

k8s-ci-robot · 2019-02-20T15:11:41Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2019-02-20T15:11:51Z

Hi @sc-chad. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2019-02-20T15:11:53Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sc-chad
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: bigkraig

If they are not already assigned, you can assign the PR to them by writing /assign @bigkraig in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…ss-controller into rails-api-examples

Jinkxed · 2019-02-20T15:18:04Z

Signed the CLA.

M00nF1sh · 2019-02-21T20:47:45Z

This is awesome! I'll take a deeper look later today 👍

M00nF1sh · 2019-02-21T20:47:55Z

/ok-to-test

M00nF1sh · 2019-02-22T21:18:08Z

docs/examples/rails-api/configmap.yaml

+metadata:
+  name: config-map
+  labels:
+    application: web


better to be app.kubernetes.io/name: rails-api, list of recommended labels: https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/

I've had issues with lookups on name versus app.kubernetes.io/name. It's probably my own understanding and how to use them. I do need to fix the labels on this config. Will add a PR.

M00nF1sh · 2019-02-22T21:19:32Z

docs/examples/rails-api/configmap.yaml

+  name: config-map
+  labels:
+    application: web
+    namespace: some-name


better to be an explicit name like rails-api-example, wonder whether we should use kustomize to layout these examples

M00nF1sh · 2019-02-22T21:22:22Z

docs/examples/rails-api/ingress-external.yaml

+    alb.ingress.kubernetes.io/certificate-arn: acm:certificate:arn
+    alb.ingress.kubernetes.io/scheme: internet-facing
+    alb.ingress.kubernetes.io/subnets: 123456789,95481321,321457987
+    alb.ingress.kubernetes.io/security-groups: sg-23157498


alb.ingress.kubernetes.io/security-groups, alb.ingress.kubernetes.io/security-subnets alb.ingress.kubernetes.io/ssl-policy should be removed. These three all have sensible default&auto-discover functionality.
Our goal is to make number annotations be as less as possible.

I added them because it wasn't intuitive that they were auto discoverable when we first walking through the examples. I can add some commenting around these to show they are optional and should be auto discovered if you've taken the appropriate steps.

What if they were included but commented out?

M00nF1sh · 2019-02-22T21:31:03Z

@sc-chad
Overall looks good to me with nit picks.
But i'm kind of resist to merge it as examples, since it's not a working example(e.g. stuffs like external DB dependencies), too many application specific details, and i'm also not sure the design goal of use both external/internal ingress for this application.

But the knowledges are valuable, like how to do external-DNS, HPA, etc. I think it's worth to break this example into smaller pieces, with each one focus on specific tasks.

Jinkxed · 2019-02-25T15:06:51Z

Added in some commenting and removed dependencies.

Jinkxed · 2019-03-08T16:26:27Z

@M00nF1sh Anything else you want me to cover here?

dennisotugo · 2019-04-05T16:06:20Z

@M00nF1sh
@bigkraig

…ontroller into rails-api-examples

zakkg3 · 2019-05-01T11:16:15Z

docs/examples/rails-api/web-external.yaml

+    kind: Deployment
+    name: web-external
+  minReplicas: 1
+  maxReplicas: 1


Why HPA with min 1 max 1? it will recreate the pod if it reaches 50% cpu?

To reduce the resources required to demo, absolutely could be 1min 2 max

fejta-bot · 2019-07-30T14:41:41Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot · 2019-08-29T15:41:00Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

dennisotugo · 2019-08-30T12:23:04Z

/remove-lifecycle rotten

dennisotugo · 2019-08-30T12:23:15Z

/remove-lifecycle stale

dennisotugo · 2019-08-30T12:23:32Z

/retest

fejta-bot · 2019-11-28T13:10:03Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

* Feature: Deferred TGB queue for no-op reconciles * account for pods that go unready and revive themself * improve logging * preempt pod readiness gate changes by clearing check point * cut v2.9.1 release --------- Co-authored-by: Zachary Nixon <[email protected]> Co-authored-by: Kubernetes Prow Robot <[email protected]>

adding additional examples on how to use annotations and healthchecks

50b5c51

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 20, 2019

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 20, 2019

k8s-ci-robot requested review from bigkraig and M00nF1sh February 20, 2019 15:11

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 20, 2019

chad-upton added 2 commits February 20, 2019 09:13

adding additional examples on how to use annotations and healthchecks

a1ae3cd

Merge branch 'rails-api-examples' of github.com:sc-chad/aws-alb-ingre…

5cddbc5

…ss-controller into rails-api-examples

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 20, 2019

Jinkxed mentioned this pull request Feb 20, 2019

Extra parameter to force usage of only one ALB per cluster #830

Closed

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 21, 2019

fixing a couple small mistakes and moving name out of annotations

56d1b06

M00nF1sh reviewed Feb 22, 2019

View reviewed changes

fixes to address some comment concerns, removed database requirements

2fb269e

missed an optional comment on the committ

eafaf1a

commenting out optional annotations

42f6a0a

Merge branch 'master' of github.com:kubernetes-sigs/aws-alb-ingress-c…

b970ebb

…ontroller into rails-api-examples

zakkg3 reviewed May 1, 2019

View reviewed changes

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 30, 2019

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 29, 2019

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 30, 2019

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 28, 2019

M00nF1sh closed this Dec 1, 2019

M00nF1sh mentioned this pull request Oct 11, 2024

cherry-pick #861 and cut v2.9.1 release #3887

Merged

6 tasks

ylee-figma mentioned this pull request Mar 6, 2025

ylee/mega target group v2.9.2 dlmather/aws-load-balancer-controller#8

Merged

adding additional examples on how to use annotations and healthchecks #861

adding additional examples on how to use annotations and healthchecks #861

Uh oh!

Conversation

Jinkxed commented Feb 20, 2019

Uh oh!

k8s-ci-robot commented Feb 20, 2019

Uh oh!

k8s-ci-robot commented Feb 20, 2019

Uh oh!

k8s-ci-robot commented Feb 20, 2019

Uh oh!

Jinkxed commented Feb 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

M00nF1sh commented Feb 21, 2019

Uh oh!

M00nF1sh commented Feb 21, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

M00nF1sh commented Feb 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jinkxed commented Feb 25, 2019

Uh oh!

Jinkxed commented Mar 8, 2019

Uh oh!

dennisotugo commented Apr 5, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fejta-bot commented Jul 30, 2019

Uh oh!

fejta-bot commented Aug 29, 2019

Uh oh!

dennisotugo commented Aug 30, 2019

Uh oh!

dennisotugo commented Aug 30, 2019

Uh oh!

dennisotugo commented Aug 30, 2019

Uh oh!

fejta-bot commented Nov 28, 2019

Uh oh!

Uh oh!

Jinkxed commented Feb 20, 2019 •

edited

Loading

M00nF1sh commented Feb 22, 2019 •

edited

Loading