Skip to content

Conversation

shraddhabang
Copy link
Collaborator

Description

Following the same strategy as of tgcfg and lbcfg to add the finalizers for rules CRD.
We will only check if the rules CRD is being referred by any L7 routes. If not, we remove the finalizers on the CRD.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shraddhabang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 24, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 24, 2025
@shraddhabang shraddhabang force-pushed the gwrulescrdfins branch 2 times, most recently from 036620a to 22de559 Compare July 25, 2025 21:27
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 25, 2025
@shraddhabang shraddhabang force-pushed the gwrulescrdfins branch 3 times, most recently from 132129a to 699a086 Compare July 25, 2025 23:21
@shuqz
Copy link
Collaborator

shuqz commented Jul 26, 2025

/lgtm /approved

@shuqz
Copy link
Collaborator

shuqz commented Jul 26, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2025
@k8s-ci-robot k8s-ci-robot merged commit f0d6d61 into kubernetes-sigs:main Jul 26, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants