-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[feat gw-api] implement grpcroute match #4270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[feat-api] refactor rule precedence code
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: shuqz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
/lgtm |
Description
implement grpcroute match
refactor code in rule precedence file, the big changes are
change priority of prefix and regex for easy of comparison, before it is exact > regex > prefix, now it is exact > prefix > regex (align with ingress)
did not add e2e test yet, did manual testing and run some existing e2e test
Checklist
README.md
, or thedocs
directory)tested with 2 yaml files below
result:

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯