Skip to content

Conversation

shuqz
Copy link
Collaborator

@shuqz shuqz commented Jul 2, 2025

Description

  • add support for httproute filter type - RequestRedirect
  • query is not supported since gateway api does not have similar attribute for user to provide this field

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
    test yaml file
  rules:
    - matches:
        - path:
            type: Exact
            value: /exactPath
      filters:
        - type: RequestRedirect # request redirect cannot be together with backendRefs
          requestRedirect:
            path:
              type: ReplaceFullPath
              replaceFullPath: "/newExactPath"
            statusCode: 301
            scheme: https
    - matches:
        - path:
            type: PathPrefix
            value: /prefixPath
      filters:
        - type: RequestRedirect # request redirect cannot be together with backendRefs
          requestRedirect:
            path:
              type: ReplacePrefixMatch
              replacePrefixMatch: "/newPrefixPath"
            scheme: http
            hostname: "a.example.com"
            port: 90

output screen
Screenshot 2025-07-01 at 5 21 51 PM
shot

  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 2, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 2, 2025
@shuqz
Copy link
Collaborator Author

shuqz commented Jul 2, 2025

/retest

isComponentSpecified = true
}

if !isComponentSpecified {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: you probably don't need this check as it's just best-effort and if clients want to create re-direct loops they can.

Copy link
Collaborator

@zac-nixon zac-nixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shuqz, zac-nixon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2025
@k8s-ci-robot k8s-ci-robot merged commit be5ec5b into kubernetes-sigs:main Jul 2, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants