clear confusion around using ClusterIP service and Instance targets #4243
+60
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/retest |
k8s-ci-robot
added
the
lgtm
wweiwei-li
reviewed
Jun 25, 2025
| @@ -181,6 +181,14 @@ func (t *defaultModelBuildTask) buildTargetGroupSpec(ctx context.Context, | |||
| } | |||
| tgPort := t.buildTargetGroupPort(ctx, targetType, svcPort) | |||
| name := t.buildTargetGroupName(ctx, k8s.NamespacedName(ing.Ing), svc, port, tgPort, targetType, tgProtocol, tgProtocolVersion) | |||
|
|
|||
| if tgPort == 0 { | |||
| if targetType == elbv2model.TargetTypeIP { | |||
There was a problem hiding this comment.
Out of curiosity, in which case, tgPort will be 0 with IP Targets ?
There was a problem hiding this comment.
technically, not possible but just being defensive in case that changes in the future.
k8s-ci-robot
removed
the
lgtm
wweiwei-li
approved these changes
Jun 25, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shraddhabang, wweiwei-li, zac-nixon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
shuqz
pushed a commit
to shuqz/shuqz-aws-load-balancer-controller
that referenced
this pull request
Jul 29, 2025
clear confusion around using ClusterIP service and Instance targets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#4238
Description
Presently, the error returned when using the wrong service type and instance targets is very unclear. In our documentation we state that you MUST use 'Loadbalancer' or 'NodePort' typed services however the error message returned by the controller does not make it obvious.
Manual testing:
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯