Skip to content

Conversation

andreybutenko
Copy link
Contributor

Issue

#4184

Description

This PR adds EKS Auto Mode considerations to documentation for ingress, ingress class, service, and target group bindings.

EKS Auto Mode has key differences from the open-source LBC. Auto Mode customers reference the LBC docs. However, LBC docs don't describe important Auto Mode-specific considerations, which can result in customers performing avoidable troubleshooting of features that are not currently supported by Auto Mode.

We want EKS docs to continue to be the authoritative source for Auto Mode considerations, but we want the Auto Mode docs to be discoverable from the LBC docs.

Design

This PR adds an notice as close as possible to the actual annotation / specifications / documentation that customers are referencing. Each notice has a link to the relevant section of the relevant EKS Auto Mode docs page.

Screenshots

Screenshot, updated ingress docs Screenshot, updated ingress class param docs Screenshot, updated service docs Screenshot, updated target group binding docs Screenshot, updated target group binding specification docs

Checklist

  • [ N/A ] Added tests that cover your change (if possible)
  • [ YES ] Added/modified documentation as required (such as the README.md, or the docs directory)
  • [ YES ] Manually tested
  • [ YES ] Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • [ N/A ] Backfilled missing tests for code in same general area 🎉
  • [ N/A ] Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 23, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @andreybutenko. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 23, 2025
Copy link
Collaborator

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreybutenko, M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2025
@k8s-ci-robot
Copy link
Contributor

@andreybutenko: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-aws-load-balancer-controller-e2e-test 87680f4 link true /test pull-aws-load-balancer-controller-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@zac-nixon zac-nixon merged commit ed4d959 into kubernetes-sigs:main May 23, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants