[bug fix] handle ram shared VPCs for cross account tgb #4095
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#4089
Description
The initial implementation didn't account for RAM shared VPCs, targets in target groups that use RAM shared VPCs can't set the AZ = 'all' as the VPC exists in the account that owns the target group.
This CR adds support to handle either peered VPCs (which will return not found when we resolve the VPC as we use the cluster accounts' credentials to resolve the VPC) and RAM shared VPCs (which will get resolved from the resolve VPC call).
I wsa able to test this out in my own cluster using a peered VPC and RAM shared VPC. Furthermore, I backfilled some missing tests and reiterated the fix details in the code.
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯