Skip to content

Conversation

Revolution1
Copy link
Contributor

@Revolution1 Revolution1 commented Oct 28, 2024

Issue

close #3913

Description

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot requested a review from kishorj October 28, 2024 15:54
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Revolution1
Once this PR has been reviewed and has the lgtm label, please assign johngmyers for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 28, 2024
@k8s-ci-robot k8s-ci-robot requested a review from M00nF1sh October 28, 2024 15:54
@k8s-ci-robot
Copy link
Contributor

Welcome @Revolution1!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 28, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @Revolution1. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 28, 2024
@kellyyan
Copy link
Contributor

kellyyan commented Nov 6, 2024

Hi, I've tested this locally and it looks good. I created a service in namespace kube-system, 2 pods in namespace echoserver and used the yaml file below. I had to add a security group rule to the cluster for it to succeed. Looping in @shraddhabang to add the ok-to-test label.

apiVersion: v1
kind: Service
metadata:
  annotations:
    service.beta.kubernetes.io/aws-load-balancer-nlb-target-type: ip
    service.beta.kubernetes.io/aws-load-balancer-scheme: internet-facing
    service.beta.kubernetes.io/aws-load-balancer-type: nlb
  name: mux
  namespace: kube-system
spec:
  loadBalancerClass: service.k8s.aws/nlb
  ports:
  - name: 1dcf5c8
    nodePort: 31718
    port: 31040
  - name: d90d676
    nodePort: 32450
    port: 31815
  type: LoadBalancer
---
apiVersion: v1
kind: Endpoints
metadata:
  name: mux
  namespace: kube-system
subsets:
- addresses:
  - ip: 192.168.35.73
    nodeName: ip-192-168-60-76.ec2.internal
    targetRef:
      kind: Pod
      name: echoserver-658d7b6fb-57crd
      namespace: echoserver
      uid: 9f30aeb9-e358-40c8-828d-f2bb3151e2b9
  ports:
  - name: d90d676
    port: 8080
    protocol: TCP
- addresses:
  - ip: 192.168.20.48
    nodeName: ip-192-168-8-65.ec2.internal
    targetRef:
      kind: Pod
      name: echoserver-658d7b6fb-82t6j
      namespace: echoserver
      uid: 8cdbff5b-0918-47aa-bce0-6c88b3663ff0
  ports:
  - name: 1dcf5c8
    port: 8080
    protocol: TCP

@shraddhabang
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 6, 2024
@shraddhabang
Copy link
Collaborator

/lgtm
/approved

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2024
@kellyyan
Copy link
Contributor

kellyyan commented Nov 8, 2024

/assign johngmyers
Pinging @johngmyers for approval

@wweiwei-li
Copy link
Collaborator

/lgtm
/approved

@wweiwei-li wweiwei-li merged commit c701a42 into kubernetes-sigs:main Nov 20, 2024
4 of 5 checks passed
@Revolution1 Revolution1 deleted the fix/use-target-namespace-to-get-pod-info-from-repo branch November 21, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot resolve Pod endpoint with selectorless service and custom Endpoints
6 participants