-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Allow disabling ingress validation via helm flag #3847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @sarevalo2002! |
Hi @sarevalo2002. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sarevalo2002 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
/lgtm |
@sarevalo2002, can you please add the manual tests you've verified in the PR description? |
@oliviassss Done! If you'd like more detail, please let me know. |
Issue
Fixes #2801.
Description
Added a flag
webhookConfig.disableIngressValidation
which when set to true, will disable Ingress validation for those who don't want Ingress resources to be validated. This is a re-implementation of the changes made in #3011 due to popular demand.Manual Testing Performed
First confirmed that manually editing
validatingwebhookconfigurations
via deleting the code block corresponding to validating ingress resulted in ingress validation being disabled (an invalid ingress was allowed to be applied after this update). Then confirmed that callinghelm upgrade
with the new flag--set webhookConfig.disableIngressValidation=true
resulted in the relevant code block mentioned previously being removed.Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯