Fix conciseLogger's incorrect call to variadic func #3066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3066 +/- ##
=======================================
Coverage 54.32% 54.32%
=======================================
Files 145 145
Lines 8410 8410
=======================================
Hits 4569 4569
Misses 3511 3511
Partials 330 330 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kishorj
approved these changes
Feb 20, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers, kishorj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
k8s-ci-robot
added
the
approved
kishorj
added
the
tide/merge-method-squash
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This was referenced Apr 14, 2023
johngmyers
pushed a commit
to johngmyers/aws-load-balancer-controller
that referenced
this pull request
Aug 21, 2023
Merge in DEL/aws-load-balancer-controller-fork from DELIVERY-8202_pull_upstream to main * commit '49805eac72ec533acdbc2580d6f57c68a9cad45c': update the default base image (kubernetes-sigs#3075) update recommended IAM policy template (kubernetes-sigs#3068) update to discovery.k8s.io/v1 (kubernetes-sigs#3072) validation ingress condition annotation in validation webhook (kubernetes-sigs#2735) Fix conciseLogger's incorrect call to variadic func (kubernetes-sigs#3066) Verify CRDs are up to date in merge check (kubernetes-sigs#3022) Refactor model builder test (kubernetes-sigs#3024)
Timothy-Dougherty
pushed a commit
to adammw/aws-load-balancer-controller
that referenced
this pull request
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #3063
Description
The adaptation of
conciseLoggerto the new go-logr API that was done in #2998 incorrectly modified the parameters of a call to a variadic receiver. This fixes that bug.Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯