Skip to content

Conversation

fawadkhaliq
Copy link
Contributor

Description
To speed review process for pull requests and have a consistent structure in managing issues, added issue and pull request templates

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 22, 2021
@k8s-ci-robot k8s-ci-robot requested review from kishorj and M00nF1sh June 22, 2021 17:32
@k8s-ci-robot
Copy link
Contributor

Hi @fawadkhaliq. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 22, 2021
@fawadkhaliq
Copy link
Contributor Author

/assign @M00nF1sh

@codecov-commenter
Copy link

Codecov Report

Merging #2089 (a02e9ba) into main (32e1987) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2089   +/-   ##
=======================================
  Coverage   49.23%   49.23%           
=======================================
  Files         130      130           
  Lines        7036     7036           
=======================================
  Hits         3464     3464           
  Misses       3294     3294           
  Partials      278      278           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32e1987...a02e9ba. Read the comment docs.

@M00nF1sh
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2021
@M00nF1sh M00nF1sh merged commit ed92ddf into kubernetes-sigs:main Jun 22, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fawadkhaliq, M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2021
@fawadkhaliq fawadkhaliq deleted the gh-templates branch June 22, 2021 17:40
@dhawal1304
Copy link

Hi All ,

Does this controller support multiple protocols e.g TCP and UDP in the same YAML.
I was not able to create one and getting the below messages.

Error syncing load balancer: failed to ensure load balancer: mixed protocol is not supported for LoadBalancer

Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants