Skip to content

Add MinLength validation to TargetGroupARN #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2021
Merged

Add MinLength validation to TargetGroupARN #2035

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28bd5f2
Add MinLength validation to TargetGroupARN
shuheiktgw May 26, 2021
ab912a1
Use = instead of :=
shuheiktgw May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apis/elbv2/v1beta1/targetgroupbinding_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ type TargetGroupBindingNetworking struct {
// TargetGroupBindingSpec defines the desired state of TargetGroupBinding
type TargetGroupBindingSpec struct {
// targetGroupARN is the Amazon Resource Name (ARN) for the TargetGroup.
// +kubebuilder:validation:MinLength:=1
Copy link
Collaborator

@M00nF1sh M00nF1sh May 27, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i believe it used to be kubebuilder:validation:MinLength=1 did +kubebuilder:validation:MinLength:=1 works as well? e.g. in https://book.kubebuilder.io/reference/generating-crd.html their example here.

Copy link
Contributor Author

@shuheiktgw shuheiktgw May 27, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review! It seems both := and = output the same manifests and https://book.kubebuilder.io/reference/markers/crd-validation.html uses := instead of =. I updated it to use = instead!

TargetGroupARN string `json:"targetGroupARN"`

// targetType is the TargetType of TargetGroup. If unspecified, it will be automatically inferred.
Expand Down
1 change: 1 addition & 0 deletions config/crd/bases/elbv2.k8s.aws_targetgroupbindings.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,7 @@ spec:
type: object
targetGroupARN:
description: targetGroupARN is the Amazon Resource Name (ARN) for the TargetGroup.
minLength: 1
type: string
targetType:
description: targetType is the TargetType of TargetGroup. If unspecified, it will be automatically inferred.
Expand Down