Skip to content

Conversation

kishorj
Copy link
Contributor

@kishorj kishorj commented May 5, 2021

The service HealthCheckNodePort is significant only whenExternalTrafficPolicy is set to Local and Type set to LoadBaalncer. Use the HealthCheckNodePort for target target group health check only in the above mentioned case. In all other case, the default health check port is traffic-port.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 5, 2021
@k8s-ci-robot k8s-ci-robot requested a review from M00nF1sh May 5, 2021 20:44
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1980 (dfbdf21) into main (57c8ce3) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1980      +/-   ##
==========================================
- Coverage   48.89%   48.87%   -0.03%     
==========================================
  Files         130      130              
  Lines        6991     6992       +1     
==========================================
- Hits         3418     3417       -1     
- Misses       3296     3297       +1     
- Partials      277      278       +1     
Impacted Files Coverage Δ
pkg/service/model_build_target_group.go 83.49% <100.00%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57c8ce3...dfbdf21. Read the comment docs.

@M00nF1sh
Copy link
Collaborator

M00nF1sh commented May 6, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishorj, M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 155e0c3 into kubernetes-sigs:main May 6, 2021
@kishorj kishorj deleted the inst-local branch May 29, 2021 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants