-
Notifications
You must be signed in to change notification settings - Fork 1.5k
add support for local zone #1920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: M00nF1sh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4316b88
to
adf4b9b
Compare
Codecov Report
@@ Coverage Diff @@
## main #1920 +/- ##
==========================================
+ Coverage 48.55% 49.18% +0.63%
==========================================
Files 113 115 +2
Lines 6319 6416 +97
==========================================
+ Hits 3068 3156 +88
- Misses 2978 2983 +5
- Partials 273 277 +4
Continue to review full report at Codecov.
|
ca535e9
to
f8792bf
Compare
/test pull-aws-load-balancer-controller-e2e-test |
f8792bf
to
8762df6
Compare
upgrade would require modifying existing IAM permissions. Lets make sure we capture this in our documentation. /lgtm |
This PR add support for local zone
Additional Notes: