Skip to content

Conversation

M00nF1sh
Copy link
Collaborator

@M00nF1sh M00nF1sh commented Apr 7, 2021

This PR add support for local zone

  1. The controller will do an additional EC2:DescribeAvailabilityZone API call for each zone to discover zone type. (the result is cached indefinitely, so at most one API call will be called for each zone in entire life of this controller)

Additional Notes:

  1. waveLength zone is currently not supported by ELB team, however, this change accounted for waveLengthZone as well, but ELBv2 API will reject the LB creation.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2021
@k8s-ci-robot k8s-ci-robot requested a review from kishorj April 7, 2021 20:36
@M00nF1sh M00nF1sh force-pushed the localzone_support branch from 4316b88 to adf4b9b Compare April 8, 2021 02:12
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 8, 2021
@codecov-io
Copy link

codecov-io commented Apr 8, 2021

Codecov Report

Merging #1920 (f8792bf) into main (e8eecf8) will increase coverage by 0.63%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1920      +/-   ##
==========================================
+ Coverage   48.55%   49.18%   +0.63%     
==========================================
  Files         113      115       +2     
  Lines        6319     6416      +97     
==========================================
+ Hits         3068     3156      +88     
- Misses       2978     2983       +5     
- Partials      273      277       +4     
Impacted Files Coverage Δ
pkg/networking/subnet_resolver.go 92.16% <76.47%> (-1.12%) ⬇️
pkg/networking/az_info_provider.go 84.61% <84.61%> (ø)
pkg/networking/az_info_provider_mocks.go 100.00% <100.00%> (ø)
pkg/ingress/group.go 100.00% <0.00%> (ø)
webhooks/networking/ingress_validator.go 56.45% <0.00%> (+0.71%) ⬆️
pkg/ingress/group_loader.go 88.40% <0.00%> (+1.24%) ⬆️
pkg/ingress/class_loader.go 86.66% <0.00%> (+4.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8eecf8...f8792bf. Read the comment docs.

@M00nF1sh M00nF1sh force-pushed the localzone_support branch 2 times, most recently from ca535e9 to f8792bf Compare April 8, 2021 02:23
@M00nF1sh
Copy link
Collaborator Author

M00nF1sh commented Apr 8, 2021

/test pull-aws-load-balancer-controller-e2e-test

@M00nF1sh M00nF1sh force-pushed the localzone_support branch from f8792bf to 8762df6 Compare April 8, 2021 18:07
@M00nF1sh M00nF1sh added the tide/merge-method-merge Denotes a PR that should use a standard merge by tide when it merges. label Apr 8, 2021
@kishorj
Copy link
Contributor

kishorj commented Apr 8, 2021

upgrade would require modifying existing IAM permissions. Lets make sure we capture this in our documentation.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit f82b48b into kubernetes-sigs:main Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-merge Denotes a PR that should use a standard merge by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants