-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Adding a note about the preservation of ALB #1919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It would be beneficial to have this also explicitly state that the ALB will not be preserved if using a version lower than v.1.1.3. In this event, based on my tests, a new load balancer is created and the old one remains. The ingress resource is updated to use the new ALB.
Welcome @nataizya-s! |
Hi @nataizya-s. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
assign @kishorj |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: M00nF1sh, nataizya-s The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It would be beneficial to have this also explicitly state that the ALB will not be preserved if using a version lower than v.1.1.3. In this event, based on my tests, a new load balancer is created and the old one remains. The ingress resource is updated to use the new ALB.
It would be beneficial to have this also explicitly state that the ALB will not be preserved if using a version lower than v.1.1.3. In this event, based on my tests, a new load balancer is created and the old one remains. The ingress resource is updated to use the new ALB.