Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/service/model_build_target_group.go
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ func (t *defaultModelBuildTask) buildTargetGroupBindingNetworking(ctx context.Co
},
},
}
if tgProtocol == corev1.ProtocolUDP || (hcPort.String() != healthCheckPortTrafficPort && hcPort.IntValue() != tgPort.IntValue()) {
if preserveClientIP || tgProtocol == corev1.ProtocolUDP || (hcPort.String() != healthCheckPortTrafficPort && hcPort.IntValue() != tgPort.IntValue()) {
var healthCheckPorts []elbv2api.NetworkingPort
networkingProtocolTCP := elbv2api.NetworkingProtocolTCP
networkingHealthCheckPort := hcPort
Expand Down
86 changes: 86 additions & 0 deletions pkg/service/model_build_target_group_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,26 @@ func Test_defaultModelBuilderTask_buildTargetGroupBindingNetworking(t *testing.T
},
},
},
{
From: []elbv2.NetworkingPeer{
{
IPBlock: &elbv2api.IPBlock{
CIDR: "172.16.0.0/19",
},
},
{
IPBlock: &elbv2api.IPBlock{
CIDR: "1.2.3.4/19",
},
},
},
Ports: []elbv2api.NetworkingPort{
{
Protocol: &networkingProtocolTCP,
Port: &port80,
},
},
},
},
},
},
Expand Down Expand Up @@ -645,6 +665,72 @@ func Test_defaultModelBuilderTask_buildTargetGroupBindingNetworking(t *testing.T
},
},
},
{
name: "tcp-service with preserve Client IP, hc is traffic port, source range specified ",
svc: &corev1.Service{
Spec: corev1.ServiceSpec{
LoadBalancerSourceRanges: []string{"10.0.0.0/16", "1.2.3.4/24"},
},
},
tgPort: port80,
hcPort: port80,
subnets: []*ec2.Subnet{
{
CidrBlock: aws.String("172.16.0.0/19"),
SubnetId: aws.String("sn-1"),
},
{
CidrBlock: aws.String("1.2.3.4/19"),
SubnetId: aws.String("sn-2"),
},
},
tgProtocol: corev1.ProtocolTCP,
preserveClientIP: true,
want: &elbv2.TargetGroupBindingNetworking{
Ingress: []elbv2.NetworkingIngressRule{
{
From: []elbv2.NetworkingPeer{
{
IPBlock: &elbv2api.IPBlock{
CIDR: "10.0.0.0/16",
},
},
{
IPBlock: &elbv2api.IPBlock{
CIDR: "1.2.3.4/24",
},
},
},
Ports: []elbv2api.NetworkingPort{
{
Protocol: &networkingProtocolTCP,
Port: &port80,
},
},
},
{
From: []elbv2.NetworkingPeer{
{
IPBlock: &elbv2api.IPBlock{
CIDR: "172.16.0.0/19",
},
},
{
IPBlock: &elbv2api.IPBlock{
CIDR: "1.2.3.4/19",
},
},
},
Ports: []elbv2api.NetworkingPort{
{
Protocol: &networkingProtocolTCP,
Port: &port80,
},
},
},
},
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion test/framework/utils/poll.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ const (
PollIntervalLong = 30 * time.Second
PollTimeoutShort = 1 * time.Minute
PollTimeoutMedium = 5 * time.Minute
PollTimeoutLong = 10 * time.Minute
PollTimeoutLong = 15 * time.Minute
)