Support for IPv6 and NLB

[csnitker]

• Added optional service.beta.kubernetes.io/aws-load-balancer-ip-address-type: (ipv4|dualstack) annotation for NLB

Implements #1655

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[codecov-io]

Codecov Report

Merging #1677 (dbb2884) into main (dbc8f00) will increase coverage by 0.08%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main    #1677      +/-   ##
==========================================
+ Coverage   46.11%   46.19%   +0.08%     
==========================================
  Files         110      110              
  Lines        5920     5933      +13     
==========================================
+ Hits         2730     2741      +11     
- Misses       2926     2927       +1     
- Partials      264      265       +1     

Impacted Files	Coverage Δ
pkg/service/model_build_load_balancer.go	82.69% <84.61%> (+0.08%)	⬆️
pkg/service/model_builder.go	77.77% <100.00%> (+0.50%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbc8f00...dbb2884. Read the comment docs.

[csnitker]

/check-cla

[keperry]

/check-cla

[keperry]

/check-cla

[kishorj]

I appreciate your efforts, thanks. Changes look good, I'm requesting for additional changes

• Lets document the annotation in the file docs/guide/service/annotations.md
• Include the tests results the PR. For example, when the annotation gets edited/removed
• Traffic tests (if any). I will do it post merge as well.

[kishorj]

Fixes #1655

[csnitker]

Just updated the documentation. We've test these changes in one of our AWS accounts and verified that adding, changing, or removing the annotation reflects on the NLB. Do we need a unit/integration test for that? If so, is there a test already setup that I can use as an example?

[kishorj]

Just updated the documentation. We've test these changes in one of our AWS accounts and verified that adding, changing, or removing the annotation reflects on the NLB. Do we need a unit/integration test for that? If so, is there a test already setup that I can use as an example?

This is good enough for now.

[M00nF1sh]

/lgtm
thanks for contributing. 👍

We'll need follow up changes to make this work for perserveSourceIP feature.
However, this is good for now since perserveSourceIP is not going to release before reinvent.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: csnitker, kishorj, M00nF1sh
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[integrii]

Bump. I am a little confused on the state of this PR. It says 'merged' but is not in the docs and appears to not be passing tests here. @M00nF1sh @csnitker

Can this feature still be a thing? This looks great.

[kishorj]

@integrii, NLB supports IPv6 in v2.1.0 and later releases and the annotation is documented in the live docs [link].

[integrii]

Ah, awesome! We were using these docs instead of the one you linked. We will try the v2.1.0 release. Thank you!