Add support for specifying NLB target group attributes #1632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
+1 for this feature. Our company is waiting on this feature to use the nlb-ip type lb. @M00nF1sh |
M00nF1sh
reviewed
Nov 13, 2020
M00nF1sh
reviewed
Nov 13, 2020
M00nF1sh
reviewed
Nov 13, 2020
M00nF1sh
reviewed
Nov 13, 2020
M00nF1sh
reviewed
Nov 13, 2020
M00nF1sh
reviewed
Nov 13, 2020
M00nF1sh
reviewed
Nov 13, 2020
M00nF1sh
reviewed
Nov 13, 2020
M00nF1sh
reviewed
Nov 13, 2020
M00nF1sh
reviewed
Nov 13, 2020
M00nF1sh
reviewed
Nov 13, 2020
M00nF1sh
reviewed
Nov 13, 2020
M00nF1sh
reviewed
Nov 13, 2020
M00nF1sh
reviewed
Nov 13, 2020
M00nF1sh
reviewed
Nov 13, 2020
kishorj
force-pushed
the
main-nlb-tg-attrs
branch
from
eefa3c0 to
4681969
Compare
M00nF1sh
reviewed
Nov 17, 2020
M00nF1sh
reviewed
Nov 17, 2020
M00nF1sh
reviewed
Nov 17, 2020
M00nF1sh
reviewed
Nov 17, 2020
M00nF1sh
reviewed
Nov 17, 2020
M00nF1sh
reviewed
Nov 18, 2020
M00nF1sh
reviewed
Nov 18, 2020
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kishorj, M00nF1sh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Timothy-Dougherty
pushed a commit
to adammw/aws-load-balancer-controller
that referenced
this pull request
Nov 9, 2023
…gs#1632) * Refactor NLB model builder * Support NLB target group attributes * add comments, unexport constants * address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for a new service annotation
service.beta.kubernetes.io/aws-load-balancer-target-group-attributesof type stringMap to allow configuring of NLB target group attributes. Issue #1570, #1611.Tests
service.beta.kubernetes.io/aws-load-balancer-target-group-attributes: stickiness.enabled=true,deregistration_delay.timeout_seconds=150,stickiness.type=source_ipservice.beta.kubernetes.io/aws-load-balancer-proxy-protocol: '*'gets precedence over the attriibutes specified