Skip to content

Conversation

M00nF1sh
Copy link
Collaborator

@M00nF1sh M00nF1sh commented Nov 6, 2020

  1. added outpost support
  2. refactor subnetResolver with below changes:
    • move resolveViaNameOrIDSlice inside subnetResolver, so it can be reused by NLB.
    • move subnet count validation logic into subnetResolver, so it can validate the count based on LB type and subnet type.
    • add a validation about locale Uniformity.(ALB requires all subnet belong to same locale)
    • add a validation about AZ Exclusivity. (ALB requires all subnet belong to different AZ).

How to use outpost subnet for ALB(NLB don't support outpost)

  1. explicitly specify one(or more) outpost subnet via subnets annotation.
  2. use subnet auto-discovery, but only tag the outpost subnet with these tags.

`

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kishorj, M00nF1sh
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@M00nF1sh M00nF1sh merged commit 26ce165 into kubernetes-sigs:main Nov 6, 2020
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants