Skip to content

fix aws session metrics #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2020
Merged

fix aws session metrics #1531

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 17 additions & 16 deletions pkg/aws/cloud.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,21 +42,8 @@ type Cloud interface {

// NewCloud constructs new Cloud implementation.
func NewCloud(cfg CloudConfig, metricsRegisterer prometheus.Registerer) (Cloud, error) {
sess := session.Must(session.NewSession(aws.NewConfig()))
injectUserAgent(&sess.Handlers)
metadata := services.NewEC2Metadata(sess)
if cfg.ThrottleConfig != nil {
throttler := throttle.NewThrottler(cfg.ThrottleConfig)
throttler.InjectHandlers(&sess.Handlers)
}
if metricsRegisterer != nil {
metricsCollector, err := metrics.NewCollector(metricsRegisterer)
if err != nil {
return nil, errors.Wrapf(err, "failed to initialize sdk metrics collector")
}
metricsCollector.InjectHandlers(&sess.Handlers)
}

metadataSess := session.Must(session.NewSession(aws.NewConfig()))
metadata := services.NewEC2Metadata(metadataSess)
if len(cfg.Region) == 0 {
region, err := metadata.Region()
if err != nil {
Expand All @@ -74,7 +61,21 @@ func NewCloud(cfg CloudConfig, metricsRegisterer prometheus.Registerer) (Cloud,
}

awsCFG := aws.NewConfig().WithRegion(cfg.Region).WithSTSRegionalEndpoint(endpoints.RegionalSTSEndpoint).WithMaxRetries(cfg.MaxRetries)
sess = session.Must(session.NewSession(awsCFG))
sess := session.Must(session.NewSession(awsCFG))
injectUserAgent(&sess.Handlers)

if cfg.ThrottleConfig != nil {
throttler := throttle.NewThrottler(cfg.ThrottleConfig)
throttler.InjectHandlers(&sess.Handlers)
}
if metricsRegisterer != nil {
metricsCollector, err := metrics.NewCollector(metricsRegisterer)
if err != nil {
return nil, errors.Wrapf(err, "failed to initialize sdk metrics collector")
}
metricsCollector.InjectHandlers(&sess.Handlers)
}

return &defaultCloud{
cfg: cfg,
ec2: services.NewEC2(sess),
Expand Down