Skip to content

Conversation

M00nF1sh
Copy link
Collaborator

@M00nF1sh M00nF1sh commented Oct 15, 2020

  1. add build Flag to populate version.
  2. remove the '--master' flag as it's deprecated by upstream as well.
  3. added a concise logger, which will no longer log these stacktraces. (which is not useful due to nested go routines).
  4. optimize the code layout

new error message:

{"level":"error","ts":1602732820.192087,"logger":"setup","msg":"unable to load controller config","error":"kubernetes cluster name must be specified"}

old error message:

{"level":"error","ts":1602732290.3767838,"logger":"setup","msg":"unable to load controller config","error":"kubernetes cluster name must be specified","errorVerbose":"kubernetes cluster name must be specified\nsigs.k8s.io/aws-load-balancer-controller/pkg/config.(*ControllerConfig).Validate\n\t/Volumes/workplace/aws-alb-ingress-controller/pkg/config/controller_config.go:63\nmain.loadControllerConfig\n\t/Volumes/workplace/aws-alb-ingress-controller/main.go:150\nmain.main\n\t/Volumes/workplace/aws-alb-ingress-controller/main.go:67\nruntime.main\n\t/usr/local/Cellar/go/1.15/libexec/src/runtime/proc.go:204\nruntime.goexit\n\t/usr/local/Cellar/go/1.15/libexec/src/runtime/asm_amd64.s:1374"}

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 15, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: M00nF1sh
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@M00nF1sh M00nF1sh merged commit 1343015 into kubernetes-sigs:v2_ga Oct 15, 2020
@M00nF1sh M00nF1sh changed the title add support for version & adjust flags echo controller version at startup and remove --master flag Oct 16, 2020
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
* code adjustments

* make the error logging concise
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants