Skip to content

Fix the iam permissions template #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2020
Merged

Fix the iam permissions template #1498

merged 1 commit into from
Oct 14, 2020

Conversation

M00nF1sh
Copy link
Collaborator

Fix the IAM permissions with below changes:

  1. limit the Tag operations by resource ARN format.
  2. the cluster tag have changed to be elbv2.k8s.aws/cluster instead of ingress.k8s.aws/cluster and service.k8s.aws/cluster
  3. added a separate iam permission needed for migration

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: M00nF1sh
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 14, 2020
@M00nF1sh M00nF1sh merged commit 3c67369 into kubernetes-sigs:v2_ga Oct 14, 2020
@M00nF1sh M00nF1sh mentioned this pull request Oct 14, 2020
Closed
@M00nF1sh M00nF1sh changed the title fix the iam permissions Fix the iam permission with centralized cluster tag Oct 16, 2020
@M00nF1sh M00nF1sh changed the title Fix the iam permission with centralized cluster tag Fix the iam permissions template Oct 16, 2020
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
@M00nF1sh @Timothy-Dougherty
fix the iam permissions (kubernetes-sigs#1498)
eafbe11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@kishorj kishorj kishorj approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@M00nF1sh @k8s-ci-robot @kishorj