-
Notifications
You must be signed in to change notification settings - Fork 1.5k
doc: workaround fix for deploying external-dns #1290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @zxkane! |
Hi @zxkane. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@zxkane Thanks for your PR. Could you port it to the main branch so that ti can be included in the v2 releases? |
@zxkane I would strongly urge you to update the example with |
Will try it. |
Codecov Report
@@ Coverage Diff @@
## main #1290 +/- ##
=======================================
Coverage 46.11% 46.11%
=======================================
Files 110 110
Lines 5920 5920
=======================================
Hits 2730 2730
Misses 2926 2926
Partials 264 264 Continue to review full report at Codecov.
|
@kishorj let me know if you have any comment for this pr for main branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
thanks for fixing this :D looks good to me.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: M00nF1sh, zxkane The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
make bitnami/external-dns working with IRSA
closes #1289