-
Notifications
You must be signed in to change notification settings - Fork 305
Update System.Text.Json dependency #791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: WeihanLi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The library is built-in as part of the shared framework for .NET Core 3.0 and later versions |
The build would fail if remove the dependency for .NET 5, the built-in version seemed is not latest version |
tests proj targets net5 as well, could you please elaborate yours |
lol this is very interesting. i tested fixing the typo and found serval build errors and understand the issue eventually. the correct way, i believe, to fix it is to fix the typo and workaround those features in .6 seems the second one is easier as netcore3.1 and net5 are approaching the eol |
b8c3950
to
a4315b2
Compare
thanks for the PR /LGTM |
System.Text.Json
dependency for .NET 6, still required for .NET 5 because of new json features introduced in6.0.0