Allow empty string text nodes #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if you try to render a node like this:
```js
text('')
```
It will go through this part of the code to get HTML escaped, however, because the `||` operator considers `''` a falsy value, it goes for `node.name` instead, which does not exist on a VDOM node. The first line in this `escapeHtml` function converts this `undefined` value to string, which ends up being the string `'undefined'`.
I think this is a bug?
Hope this helps!
frenzzy
approved these changes
Jun 29, 2022
|
Just released under v4.0.1 🎉 Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you try to render a node like this:
It will actually render
undefined🤔It goes through this part of the code to get HTML escaped, however, because the
||operator considers''a falsy value, it goes fornode.nameinstead, which does not exist on a VDOM node. The first line in thisescapeHtmlfunction converts thisundefinedvalue to string, which ends up being the string'undefined'.I think this is a bug?
Hope this helps!
Types of changes
Checklist: