Initial work on a queue sidebar panel #294
Conversation
greeeeeenbean
changed the title
|
Hey @kraxarn! Any thoughts on this? Happy to jump into discord or something to discuss |
There was a problem hiding this comment.
Sorry it took so long to get around to this, life tends to happen 😅
I think the main problem I have with this PR is that it does too much. Too many unrelated features are combined in a single PR, which makes it difficult to review and track changes made. There are also some changes I'm not quite sure if I want, like live search, and I'm not sure if I get the entire point of having a dedicated list for the queue.
| set(CMAKE_AUTOMOC ON) | ||
| set(CMAKE_AUTORCC ON) | ||
|
|
||
| list(APPEND CMAKE_PREFIX_PATH "~/Qt/6.3.0/gcc_64") |
| /** | ||
| * Swap song name and artist name order in queue (Artist - Song instead of Song - Artist) | ||
| */ | ||
| bool queue_swap_name_format = false; |
There was a problem hiding this comment.
Adding new settings would be a breaking change that I'm not ready to merge right now, but I'm also not really sure if I like this, as it's a bit too specific
| new MainMenuBar(spotify, settings, httpClient, cache, this); | ||
| } | ||
|
|
||
| // Queue dock widget is initially hidden and can be toggled via the toolbar button |
There was a problem hiding this comment.
Comments like these exist in a couple of places that provide no additional information that the code itself already doesn't, comments are for describing why, not what.
2 participants
Hi all,
I really wanted to have a way to see the queue and interact with it outside of the dropdown menu. I will be 100% honest, about half of this is ollama assisted, I'm not primarily a QT dev so this was mostly for my use. Feel free to decline :P
Here's a few screenshots:
Features include:
Edit... forgot to add I also added a live search feature requested in #243