Skip to content

fix: Exception Handler not convert ApiResponse to JsonResponse #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 23, 2022
Merged

fix: Exception Handler not convert ApiResponse to JsonResponse #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6af1492
fix: ExceptionHandler not convert ApiResponse to JsonResponse
axmad386 Dec 22, 2022
09cb931
docs: update explanation how to use renderAsApiResponse method
axmad386 Dec 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ public function register()
{
$this->renderable(function (Throwable $e, $request) {
if ($request->wantsJson() || $request->is('*api*')) {
return ApiExceptionHandler::renderAsApiResponse($e);
return ApiExceptionHandler::renderAsApiResponse($e, $request);
}
});
}
Expand All @@ -146,7 +146,7 @@ public function register()
public function render($request, Throwable $exception)
{
if ($request->wantsJson() || $request->is('*api*')) {
return ApiExceptionHandler::renderAsApiResponse($exception);
return ApiExceptionHandler::renderAsApiResponse($exception, $request);
}

return parent::render($request, $exception);
Expand Down
2 changes: 1 addition & 1 deletion src/ExceptionHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public static function renderAsApiResponse(Throwable $e, Request $request = null
$request = $request ?? request();

if ($e instanceof ApiException) {
return $e->render();
return $e->render()->toResponse($request);
}

try {
Expand Down