Skip to content
This repository was archived by the owner on Jan 9, 2025. It is now read-only.

Conversation

@obatirou
Copy link
Collaborator

@obatirou obatirou commented Oct 10, 2024

Time spent on this PR:

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves #1488

What is the new behavior?

Coinbase use Ownable2Step from OZ with version 5.0.2


This change is Reviewable

@obatirou obatirou changed the title feat: Ownable 2 step coinbase feat: Ownable2Step coinbase Oct 10, 2024
@obatirou obatirou force-pushed the ownable-2-steps-coinbase branch from 307cb8a to 3cf0174 Compare October 10, 2024 15:43
Copy link
Member

@ClementWalter ClementWalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the openzeppeline contracts are already in the submodules

@obatirou obatirou force-pushed the ownable-2-steps-coinbase branch from bd06c65 to 28445e1 Compare October 11, 2024 09:11
@ClementWalter ClementWalter merged commit b04587d into kkrt-labs:main Oct 11, 2024
13 checks passed
matthieuauger pushed a commit to matthieuauger/kakarot that referenced this pull request Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Upgrade OZ and use Ownable2Step for Coinbase

2 participants