fix(webrtc): Implement flow control to prevent dropped connections #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The uploader was sending data chunks without waiting for acknowledgment, causing the receiver's buffer to overflow and the WebRTC connection to terminate, especially when the download was paused by a 'Save As' dialog. This change introduces a stop-and-wait flow control mechanism. The uploader now sends a chunk and waits for a ChunkAck message from the downloader before sending the next one. This stabilizes the connection and makes file transfers more reliable. Fixes kern#272
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The uploader was sending data chunks without waiting for acknowledgment, causing the receiver's buffer to overflow and the WebRTC connection to terminate, especially when the download was paused by a 'Save As' dialog.
This change introduces a stop-and-wait flow control mechanism. The uploader now sends a chunk and waits for a ChunkAck message from the downloader before sending the next one. This stabilizes the connection and makes file transfers more reliable.
Fixes #272