- 
                Notifications
    You must be signed in to change notification settings 
- Fork 17
          Updated documentation regarding DistributedEmbedding batch size.
          #138
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @hertschuh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on improving the clarity and accuracy of documentation related to batch size interpretation within the DistributedEmbedding layer's FeatureConfig. The changes ensure that users understand that the input_shape and output_shape parameters refer to the global batch size in a distributed context, and updates corresponding code examples to align with this clarification.
Highlights
- Documentation Clarity: Clarified the documentation for FeatureConfigwithinDistributedEmbedding, specifically noting that the first dimension ofinput_shapeandoutput_shaperepresents the global batch size. This is particularly important for distributed training environments, such as those utilizing TPUs, where the global batch size refers to the total number of samples dispatched across all devices.
- Code Example Alignment: Updated an internal code example in base_distributed_embedding.pyto reflect the global batch size concept. TheFeatureConfiginstances in the example now explicitly useGLOBAL_BATCH_SIZEinstead ofPER_REPLICA_BATCH_SIZEfor theirinput_shapeandoutput_shapeparameters, ensuring consistency with the clarified documentation.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description | 
|---|---|---|
| Code Review | /gemini review | Performs a code review for the current pull request in its current state. | 
| Pull Request Summary | /gemini summary | Provides a summary of the current pull request in its current state. | 
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. | 
| Help | /gemini help | Displays a list of available commands. | 
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
- 
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩ 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the documentation for DistributedEmbedding to clarify that the batch size in FeatureConfig refers to the global batch size, not the per-replica batch size. The changes include updating the docstring in FeatureConfig and an example in DistributedEmbedding.
The batch size represented by the first dimension of `input_shape` and `output_shape` in `FeatureConfig` is the global batch size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The batch size represented by the first dimension of
input_shapeandoutput_shapeinFeatureConfigis the global batch size.