Skip to content

Conversation

@hertschuh
Copy link
Collaborator

The batch size represented by the first dimension of input_shape and output_shape in FeatureConfig is the global batch size.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @hertschuh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the clarity and accuracy of documentation related to batch size interpretation within the DistributedEmbedding layer's FeatureConfig. The changes ensure that users understand that the input_shape and output_shape parameters refer to the global batch size in a distributed context, and updates corresponding code examples to align with this clarification.

Highlights

  • Documentation Clarity: Clarified the documentation for FeatureConfig within DistributedEmbedding, specifically noting that the first dimension of input_shape and output_shape represents the global batch size. This is particularly important for distributed training environments, such as those utilizing TPUs, where the global batch size refers to the total number of samples dispatched across all devices.
  • Code Example Alignment: Updated an internal code example in base_distributed_embedding.py to reflect the global batch size concept. The FeatureConfig instances in the example now explicitly use GLOBAL_BATCH_SIZE instead of PER_REPLICA_BATCH_SIZE for their input_shape and output_shape parameters, ensuring consistency with the clarified documentation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation for DistributedEmbedding to clarify that the batch size in FeatureConfig refers to the global batch size, not the per-replica batch size. The changes include updating the docstring in FeatureConfig and an example in DistributedEmbedding.

The batch size represented by the first dimension of `input_shape` and `output_shape` in `FeatureConfig` is the global batch size.
Copy link
Collaborator

@abheesht17 abheesht17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hertschuh hertschuh merged commit fc91f77 into keras-team:main Aug 5, 2025
5 checks passed
@hertschuh hertschuh deleted the batch_size branch August 5, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants