clarified timing attack note in README #1207
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clarifies the section "A Note on Timing Attacks" in README.md
The original wording was confusing regarding why bcrypt is time-safe despite the comparison function not being time-safe (see issue #956 )
I also considered noting that an attacker could theoretically gain some information (the first 1-2 bytes of the stored hash) with brute force, but decided to stick with the original security claim that there is no information leaked.