Get kdl property value span

[ggallovalle]

How can I reliably get the span of the actual property value.

I can rely on the following

• entry.span() -> for the whole property span
• entry.ty().unwrap().span() -> for the type annotation of the property value
• entry.name().unwrap().span() -> for the property name

but the only thing that is missing is how to get the span corresponding to the value without all the KdlEntryFormat

For example right now I can't seem to reliably point to the value "hello" without all the fuss of the format

[zkat]

Yeah this isn’t supported right now, but should be!

[ggallovalle]

Hi, I had a go at it and I can get the span that I expect

In v2_parser.rs

fn value(input: &mut Input<'_>) -> PResult<Option<KdlEntry>> {
    let ((ty, ((value, raw), value_span)), _span) = trace(
        "value",
        (
            opt((ty, node_space0.take())),
            alt((keyword.map(Some), number.map(Some), string)).with_taken().with_span(),
        ),
    )
    .with_span()
    .parse_next(input)?;
}

I would like to make a PR for this, how would you recommend this value be exposed? I was thinking something like

pub struct KdlEntry {
    #[cfg(feature = "span")]
    pub(crate) span_value: SourceSpan,
}

impl KdlEntry {
    #[cfg(feature = "span")]
    pub fn span_value(&self) -> SourceSpan {
        self.span_value
    }
}