✨ Label local objects with the agent name #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erve the same API On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
kcp-ci-bot
added
release-note
|
LGTM label has been added. Git tree hash: e8e8f77529a01c138a29945b24e9c3220a42d113
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If two or more Sync Agents work on the same local cluster (but each talking to its own kcp), and they both serve the same local API (i.e. there are 2 PublishedResources that describe the same local API), they will get confused over each other's objects. When Agent 1 syncs an object from kcp 1 to the local cluster, Agent 2 might think it own it. The severity of this issue also depends on object naming (if for example the kcp cluster names are included in the local object names, for example as namespaces, then a collision is less likely since cluster names should be globally unique).
To improve the situation, this PR uses the already existing agent name to label local objects, declaring ownership over them. This does not mean 2 PublishedResources can now lead to conflicts (object A in kcp 1 and object B in kcp 2 both getting synced down into the same local object), that is still forbidden. This PR is more about preventing accidental overlaps, where the Agent by accident reconciles the wrong objects.
Related issue(s)
Fixes #13
Release Notes