Skip to content

Conversation

@zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #384

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe added the enhancement New feature or request label Oct 16, 2024
@zong-zhe zong-zhe requested a review from Peefy October 16, 2024 11:52
@zong-zhe zong-zhe self-assigned this Oct 16, 2024
@coveralls
Copy link

coveralls commented Oct 16, 2024

Pull Request Test Coverage Report for Build 11472491088

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 26 of 124 (20.97%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.4%) to 41.569%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/client/deperated.go 0 3 0.0%
pkg/utils/utils.go 6 17 35.29%
pkg/downloader/source.go 0 35 0.0%
pkg/downloader/downloader.go 20 69 28.99%
Files with Coverage Reduction New Missed Lines %
pkg/downloader/downloader.go 1 30.5%
pkg/client/deperated.go 2 41.27%
Totals Coverage Status
Change from base Build 11363980156: -0.4%
Covered Lines: 3604
Relevant Lines: 8670

💛 - Coveralls

@zong-zhe zong-zhe changed the title [WIP] feat: add OciCache to support the new local file structure for OCI feat: add OciCache to support the new local file structure for OCI Oct 17, 2024
@Peefy
Copy link
Contributor

Peefy commented Oct 17, 2024

I think the Cache interface will be implemented using different caching strategies rather than targeting different sources. Different Sources have already implemented different hash name storage paths.

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 1566616 into kcl-lang:main Oct 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Enhancement: kpm add command displaying optimization

3 participants