Skip to content

Conversation

@Haarolean
Copy link
Member

@Haarolean Haarolean commented Feb 1, 2024

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Fixed user mapping in audit.
Now works with:

  • no auth
  • form login
  • oauth
  • ldap
  • rbac

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Haarolean Haarolean added scope/backend Related to backend changes type/bug Something isn't working area/audit labels Feb 1, 2024
@Haarolean Haarolean requested a review from iliax February 1, 2024 12:39
@Haarolean Haarolean self-assigned this Feb 1, 2024
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress type/feature A brand new feature status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Feb 1, 2024
@Haarolean Haarolean linked an issue Feb 1, 2024 that may be closed by this pull request
@Haarolean Haarolean removed type/feature A brand new feature status/triage/manual Manual triage in progress labels Feb 1, 2024
@Haarolean Haarolean merged commit 7b44dd3 into main Feb 17, 2024
@Haarolean Haarolean deleted the issues/79 branch February 17, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/audit scope/backend Related to backend changes status/triage/completed Automatic triage completed type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audit: ClassCastException when OAuth is enabled

3 participants