Skip to content

Conversation

@jtpio
Copy link
Member

@jtpio jtpio commented Sep 25, 2020

Fixes #71.

We should check whether we want to have strictNullChecks set to true by default in the cookiecutter for 3.0, as this might also require updating a couple of other places that depend on the cookiecutter and use the python -m jupyterlab.upgrade_extension script:

@jtpio
Copy link
Member Author

jtpio commented Sep 30, 2020

cc @afshin what do you think about having this on by default for 3.0?

@jtpio jtpio changed the base branch from 3.0 to master January 20, 2021 09:27
@jtpio jtpio changed the base branch from master to 3.0 January 27, 2021 08:15
@fcollonval
Copy link
Member

I think we could merge this one, no?

@jtpio
Copy link
Member Author

jtpio commented May 21, 2021

Yes I think so too.

@blink1073 blink1073 merged commit 62219a8 into jupyterlab:3.0 May 21, 2021
@jtpio jtpio deleted the strict-null-checks branch May 21, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Strict null checks should default to true

3 participants