Skip to content

Conversation

@fcollonval
Copy link
Member

@fcollonval fcollonval commented Dec 15, 2022

Add the [test] dep group only when needed.
Add the [test] group to the pip install command when needed
Add the linking command to avoid confusion after only triggering pip install

@jtpio
Copy link
Member

jtpio commented Dec 17, 2022

Or maybe the test optional dependencies array should not be defined if testing is not selected when generating the extension? (currently it defaults to an empty list)

Maybe it can be confusing to run pip install -e ".[test]" if they didn't choose to add tests.

@fcollonval fcollonval changed the title Add [test] in README Improve [test] template conditioning Dec 19, 2022
@fcollonval
Copy link
Member Author

Or maybe the test optional dependencies array should not be defined if testing is not selected when generating the extension? (currently it defaults to an empty list)

Maybe it can be confusing to run pip install -e ".[test]" if they didn't choose to add tests.

Done thanks for the review

@fcollonval fcollonval merged commit b501d78 into 3.0 Dec 20, 2022
@fcollonval fcollonval deleted the fcollonval-patch-2 branch December 20, 2022 15:40
@fcollonval
Copy link
Member Author

@meeseeksdev please backport to 4.0

meeseeksmachine pushed a commit to meeseeksmachine/extension-cookiecutter-ts that referenced this pull request Dec 20, 2022
fcollonval added a commit that referenced this pull request Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants