-
-
Couldn't load subscription status.
- Fork 87
Update versions of GH actions #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c8c60be to
2fb458d
Compare
|
This PR and scheduled checks are failing on Python 3.11 with: |
|
We need to explicitly use it by adding the dependency there
and switching the configuration there
The later command is the reason of the error because it ends up loading that configuration file requiring |
| test = [{% if cookiecutter.test.lower().startswith('y') %} | ||
| "coverage", | ||
| "pytest", | ||
| "pytest-asyncio", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't need pytest-asyncio or pytest-tornasync if you're using pytest-jupyter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, you'd need pytest-asyncio in order to write async fixtures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @blink1073
I removed pytest-tornasync
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
|
@meeseeksdev please backport to 3.0 |
Co-authored-by: Michał Krassowski <[email protected]>
Gets rid of Node 12 deprecation warnings