Skip to content

Conversation

@blink1073
Copy link
Contributor

@blink1073
Copy link
Contributor Author

@fcollonval this approach won't work unless we backport the changes to federated_labextensions.py to look for the package name in pyproject.toml first.

@ofek
Copy link

ofek commented Sep 11, 2022

@agoose77
Copy link
Contributor

@blink1073 I'm not sure I'm following. Do you mean for older JupyterLab versions that won't have the latest federated_labextensions.py?

@agoose77
Copy link
Contributor

I realised that the docs weren't clear for the metadata hook, so I've updated them. The fields setting corresponds to the names in the pyproject.toml file that are provided by the extension. This is so that other metadata plugins can be used alongside this extension (as hatch-nodejs-version does more than one thing).

@blink1073
Copy link
Contributor Author

Do you mean for older JupyterLab versions that won't have the latest federated_labextensions.py?

Yes, the changes are in 4.0alpha but have not been backported to 3.x yet.

@blink1073
Copy link
Contributor Author

@blink1073 blink1073 merged commit 1218eb1 into jupyterlab:3.0 Sep 13, 2022
@blink1073 blink1073 deleted the use-nodejs-version branch September 13, 2022 14:56
razrotenberg added a commit to run-ai/jupyterlab_genv that referenced this pull request Sep 21, 2022
* tbump failed with a weird error
* Followed this update of the cookiecutter template: jupyterlab/extension-cookiecutter-ts#230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants