Skip to content

Use more information from package.json in setup.py #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2022
Merged

Use more information from package.json in setup.py #204

merged 1 commit into from
Feb 11, 2022

Conversation

@fcollonval
Copy link
Member

Use package.json to get:

  • the output directory with extension assets
  • the frontend package name

jtpio
jtpio approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 9d55080 into jupyterlab:3.0 Feb 11, 2022
@fcollonval fcollonval deleted the ft/maximize-extraction-from-package-json branch February 12, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtpio jtpio jtpio approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fcollonval @jtpio