Skip to content

Conversation

@xiaohk
Copy link
Contributor

@xiaohk xiaohk commented Nov 4, 2021

The file check-release.yml should be rendered by cookiecutter because it uses cookiecutter variable cookiecutter.python_name (line 59).

name: {{ cookiecutter.python_name }}-releaser-dist-${{ github.run_number }}

@welcome
Copy link

welcome bot commented Nov 4, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @xiaohk I have an optional suggestion otherwise LGTM.

Co-authored-by: Frédéric Collonval <[email protected]>
@xiaohk
Copy link
Contributor Author

xiaohk commented Nov 5, 2021

Thanks @fcollonval! Agreed, your way to escape double curly brace (#189 (comment)) is much easier to read! I have committed the suggested change.

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xiaohk

@xiaohk
Copy link
Contributor Author

xiaohk commented Nov 5, 2021

@fcollonval I am not sure why some test are timed out 🙁

@fcollonval
Copy link
Member

Kicking CI

@fcollonval fcollonval closed this Nov 7, 2021
@fcollonval fcollonval reopened this Nov 7, 2021
@fcollonval fcollonval merged commit 1657093 into jupyterlab:3.0 Nov 7, 2021
@welcome
Copy link

welcome bot commented Nov 7, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants