-
-
Notifications
You must be signed in to change notification settings - Fork 87
Let cookiecutter render check-release.yml #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jay Wang <[email protected]>
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
Signed-off-by: Jay Wang <[email protected]>
{{cookiecutter.python_name}}/.github/workflows/check-release.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @xiaohk I have an optional suggestion otherwise LGTM.
Co-authored-by: Frédéric Collonval <[email protected]>
|
Thanks @fcollonval! Agreed, your way to escape double curly brace (#189 (comment)) is much easier to read! I have committed the suggested change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @xiaohk
|
@fcollonval I am not sure why some test are timed out 🙁 |
|
Kicking CI |


The file
check-release.ymlshould be rendered by cookiecutter because it uses cookiecutter variablecookiecutter.python_name(line 59).extension-cookiecutter-ts/{{cookiecutter.python_name}}/.github/workflows/check-release.yml
Line 59 in 6d1b8c6