Include LICENSE file explicitly in package #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings the bullet formatting in line with the text at https://opensource.org/licenses/BSD-3-Clause and the default BSD text from GitHub, as well as with the JupyterLab license file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reformats the bullet points of the license file to be in line with the jlab license, the OSI text, and the default GitHub bsd license text (numbered bullet points). It also moves the "All rights reserved" down to its own line, in line with the GitHub bsd license text.
Finally, we add the license_file keyword to setup.py to make sure we are explicitly requiring the license file in the package (rather than relying on the default behavior to include it).