-
-
Notifications
You must be signed in to change notification settings - Fork 87
Require jupyter-packaging as setup deps #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The real problem is the command It raises: as it calls command such @blink1073 @jtpio @krassowski what do you think? |
|
I would like to add that current changes in this PR also fix another issue for me: when trying to manually build python source archive and a wheel with On 3.0, this manual build process gives: $ jupyter server extension list
Config dir: /home/jovyan/.jupyter
Config dir: /opt/conda/etc/jupyter
jupyterlab enabled
- Validating jupyterlab...
jupyterlab 3.0.16 OK
nbclassic enabled
- Validating nbclassic...
nbclassic OK
Config dir: /usr/local/etc/jupyter
$ jupyter labextension list
JupyterLab v3.0.16and on the fix/setup_py: $ jupyter server extension list
Config dir: /home/jovyan/.jupyter
Config dir: /opt/conda/etc/jupyter
jupyterlab enabled
- Validating jupyterlab...
jupyterlab 3.0.16 OK
myextension enabled
- Validating myextension...
myextension 0.1.0 OK
nbclassic enabled
- Validating nbclassic...
nbclassic OK
Config dir: /usr/local/etc/jupyter
$ jupyter labextension list
JupyterLab v3.0.16
/opt/conda/share/jupyter/labextensions
myextension v0.1.0 enabled OK (python, myextension) |
Except if we are introspecting the name or version (eg jupyter lab build tools)
|
Here is a new version that raises an error when
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
|
@fcollonval I confirm that it solves my issue, thank you for solving it! |
|
This works great - thanks! |
Fixes #159
Fixes #167
The data files should not be conditionned on anything => jupyter packaging needs to be installed as setup dependencies.