Skip to content

Set extension name first and derive python name #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 14, 2021
Merged

Set extension name first and derive python name #161

merged 3 commits into from
Jun 14, 2021

Conversation

@fcollonval
Copy link
Member

Fixes #160

blink1073
blink1073 approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@blink1073 blink1073 merged commit cd03900 into jupyterlab:3.0 Jun 14, 2021
@fcollonval fcollonval deleted the fcollonval/issue160 branch June 14, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@blink1073 blink1073 blink1073 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can't initialize cookiecutter or clone the git repo on Windows

2 participants

@fcollonval @blink1073