Skip to content

Conversation

@goanpeca
Copy link
Member

@goanpeca goanpeca commented Jun 4, 2021

The docs point to using

https://jupyterlab.readthedocs.io/en/stable/extension/extension_tutorial.html#build-and-install-the-extension-for-development

pip install -e . and jupyter labextension develop --overwrite .

But the second command is missing in the binder postBuild

@goanpeca goanpeca force-pushed the fix/binder-install branch from 10f6018 to 3b53770 Compare June 4, 2021 17:23
@fcollonval
Copy link
Member

As stated in the mentioned link, the develop command allows to create a symbolic link from JupyterLab to our source directory. By default with pip install -e, the files will be copied not symlinked. So for binder this is ok not to run the develop command.

@goanpeca
Copy link
Member Author

goanpeca commented Jun 4, 2021

I made a PR the last days because this extension (https://github.com/deshaw/jupyterlab-execute-time) was not working on binder (nor locally for dev mode) if I did pip install -e .

:-|

Do I need to install jupyter-packaging for pip install -e . to do the right thing ?

https://github.com/jupyterlab/extension-cookiecutter-ts/blob/3.0/%7B%7Bcookiecutter.python_name%7D%7D/setup.py#L72

Is that is the case then we would need to add that to environment.yml since it is not longer on install-requires ?

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this makes sense because pip does not handle data_files in develop mode.

@blink1073 blink1073 merged commit c5bf4ae into jupyterlab:3.0 Jun 4, 2021
@goanpeca goanpeca deleted the fix/binder-install branch June 4, 2021 20:26
@fcollonval
Copy link
Member

Ho yep sorry @goanpeca I forgot that now jupyter-packaging is optional. So thanks @blink1073 for merging this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants