Skip to content

Conversation

@fcollonval
Copy link
Member

@fcollonval fcollonval commented Jun 4, 2021

People tends to use dash in python name. This creates invalid python package name.

This proposal convert the python folder to use _ instead of -. But the package name keeps the dash (for example when publishing on pypi).

This PR restructured the CI to separate test cases in different jobs.

@fcollonval fcollonval marked this pull request as ready for review June 4, 2021 12:07
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 03b1a97 into jupyterlab:3.0 Jun 4, 2021
@fcollonval fcollonval deleted the fix/py-name branch June 4, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants