Skip to content

Conversation

@s-weigand
Copy link
Contributor

First of all thanks for the cookiecutter template ❤️

Sadly it doesn't always work out of the box.

When creating a new extension and choosing has_binder [n]: y the initial push fails due to check-manifest complaining about the binder folder not being in the MANIFEST.in.
Since the binder settings aren't needed for the extension itself, this can be fixed by excluding them from packaging.

After fixing this there is an error caused by popd (directory stack empty) since pushd wasn't used in the workflow.

After removing popd from the workflow template a freshly created extension passes the CI.

s-weigand added 2 commits May 21, 2021 07:41
This causes a 'directory stack empty' error
@welcome
Copy link

welcome bot commented May 21, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit 7aa4be9 into jupyterlab:3.0 May 21, 2021
@welcome
Copy link

welcome bot commented May 21, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@s-weigand s-weigand deleted the prune-binder branch May 21, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants