Skip to content

Match markedjs behavior for parsing HTML linebreaks #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Match markedjs behavior for parsing HTML linebreaks #1763

wants to merge 2 commits into from

Conversation

martinRenou
Copy link
Member

Marked JS (used in JupyterLab and Jupyter Notebook) had a small behavior difference when parsing line breaks:

<p>
Line 1

Line2
</p>

linebreaks

Behavior in nbconvert prior to this PR:

before

Behavior in nbconvert after this PR:

after

fcollonval
fcollonval reviewed Apr 20, 2022
View reviewed changes
@martinRenou martinRenou marked this pull request as draft April 20, 2022 12:19
@martinRenou
Copy link
Member Author

I've got a working solution but I am really not happy with the implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@fcollonval fcollonval fcollonval left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinRenou @fcollonval