NAME_GENERATOR gets request object, minor cleanups #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onsidering the request when generating the username.
…d proper dependencies
- Creates a single workflow that consolidates lint, test, and test-example jobs - Implements proper job dependencies: lint → test → test-example - Ensures each job only runs if previous jobs succeed - Maintains all existing functionality while adding dependency management - Provides better workflow visualization and control
- Replace bare except clauses with specific Exception handling (E722) - Remove unused variables 'description' and 'category' (F841) - Remove trailing whitespace (W291) - Fix f-string formatting issues (F541) - Clean up HTML string formatting for better readability
- Replace star import with specific imports to fix F403/F405 errors - Import only needed items from main settings module - Maintain all existing functionality while resolving linting issues - Ensures BASE_DIR, SECRET_KEY, MIDDLEWARE are properly defined
- Add Poetry installation step using snok/install-poetry@v1 - Update caching to include Poetry venv and dependencies - Replace manual pip installations with Poetry commands - Use `poetry install --with dev` to install development dependencies - Add Playwright installation through Poetry - Update all Django management commands to use `poetry run` - Maintain existing functionality while using Poetry's dependency management
- Change Python version from 3.11 to 3.12 in test-example job - This ensures the test project uses the latest Python version for integration testing
- Update Django version in dev dependencies from ^4.2.5 to ^5.2.0 - This ensures the test project uses Django 5.2 as requested - Maintains compatibility with older Django versions in main dependencies
- Change main Python requirement from >=3.9 to >=3.10 - Remove Python 3.9 from classifiers since Django 5.2 requires Python 3.10+ - Update Black target-version to reflect new minimum Python version - This resolves Poetry dependency resolution issues with Django 5.2
|
Hey I'd be interested in seeing your contributions in this project but not as one giant PR. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pass request object to NAME_GENERATOR if available. this allows for considering the request when generating the username.