Skip to content

Conversation

@imolorhe
Copy link
Collaborator

@imolorhe imolorhe commented Jun 5, 2024

Some issues (#89, #69) have been fixed upstream in json-schema-library. We just need to use the updated version to get these issues resolved.

@changeset-bot
Copy link

changeset-bot bot commented Jun 5, 2024

🦋 Changeset detected

Latest commit: 64f5bd0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
codemirror-json-schema Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@imolorhe imolorhe requested a review from acao June 5, 2024 19:32
@netlify
Copy link

netlify bot commented Jun 5, 2024

Deploy Preview for codemirror-json-schema ready!

Name Link
🔨 Latest commit 658e5f5
🔍 Latest deploy log https://app.netlify.com/sites/codemirror-json-schema/deploys/6660bd65aebd43000896b01f
😎 Deploy Preview https://deploy-preview-123--codemirror-json-schema.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jun 5, 2024

Deploy Preview for codemirror-json-schema ready!

Name Link
🔨 Latest commit 64f5bd0
🔍 Latest deploy log https://app.netlify.com/sites/codemirror-json-schema/deploys/6660bd7200d5ce0008a61640
😎 Deploy Preview https://deploy-preview-123--codemirror-json-schema.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@acao acao merged commit 2356a94 into main Jun 5, 2024
@acao acao deleted the imolorhe/update-json-schema-library branch June 5, 2024 21:17
@github-actions github-actions bot mentioned this pull request Jun 5, 2024
acao pushed a commit that referenced this pull request Jun 5, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## [email protected]

### Patch Changes

- [#122](#122)
[`c2dfcc1`](c2dfcc1)
Thanks [@imolorhe](https://github.com/imolorhe)! - fix demo highlighting

- [#123](#123)
[`2356a94`](2356a94)
Thanks [@imolorhe](https://github.com/imolorhe)! - updated
json-schema-library to get upstream fixes

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

jsonschema rules for array type does not get all applied during validation Expected type not working

3 participants